add prctl constants on android #4531
Conversation
|
Some changes occurred in the Android module cc @maurer |
rustbot
added
the
stable-nominated
|
I am not sure if those FreeBSD failures have anything to do with my change. The errors appear to be about a missing symbol that only appears in the FreeBSD path. |
| #[cfg_attr(termux, link(name = "android-posix-semaphore"))] | ||
| extern "C" {} |
There was a problem hiding this comment.
On Android's bionic, there are some libc functions which are not supported, like sem_open, sem_close, and sem_unlink, which causes link failures when compiling anything with libc as a dependency.
On the Android terminal app Termux, there is a substitute port available as a separate library, which must be linked in explicitly.
| | "toupper" | "getpwuid_r" | "tmpfile" | "getpwnam" | "getpwuid" | "tcdrain" | ||
| | "cfgetispeed" | "cfgetospeed" | "cfsetispeed" | "cfsetospeed" | "tcgetattr" | ||
| | "tcsetattr" | "tcflow" | "tcflush" | "tcgetsid" | "tcsendbreak" | "cfmakeraw" | ||
| | "cfsetspeed" => true, |
There was a problem hiding this comment.
These don't seem relevant to the change here
There was a problem hiding this comment.
It's not strictly related, but tests for all these functions fail currently.
I split it out into another commit to make that clearer
Add all constants from bionic's `prctl.h` header https://android.googlesource.com/platform/bionic/+/7ac54f5c391bf3aeb9fec84a158939421fd8f505/libc/kernel/uapi/linux/prctl.h
* ignore tests on some symbols that fail with bad function pointers * detect termux app and link `libandroid-posix-semaphore` to fix link errors
dead10ck
force-pushed
the
fix/android/prctl
branch
from
e9789f7 to
f5e4401
Compare
Description
Add all constants from bionic's
prctl.hheaderSources
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI
@rustbot label +stable-nominated